Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API's to get withdraw_permission objects related to an account #611

Closed
abitmore opened this issue Jan 30, 2018 · 4 comments
Closed

Comments

@abitmore
Copy link
Member

Listing some tasks need to be done in the core for #540 in this ticket, since that ticket may be mainly for discussion.

  • query by giver
  • query by recipient
@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Jan 30, 2018
@oxarbitrage
Copy link
Member

i have a few options on how to this:

1- we make this as a plugin (recurring_plugin) and move the indexes of withdraw_permission_object into there just as account_history does. can have the option to save in elasticsearch database.
or
2- create a new recurring_api in api.cpp and don't move index.
or
3- just create the call needed in database_api.cpp

@abitmore
Copy link
Member Author

abitmore commented Feb 5, 2018

Not like history objects, withdraw_permission objects need to be created in core. The by_expiration indices is being used in consensus. Other indices are not being used so far. If an index is useless in core, it's OK to have it in a plugin, but this may need some efforts, also don't know if we need to move it back to core for consensus which may get more work involved. Since RAM for this object type would not be a problem in a period, I suggest we just leave it in core. As a result, best add the API as a database API.

@oxarbitrage oxarbitrage self-assigned this Feb 8, 2018
@oxarbitrage
Copy link
Member

bitshares/bitshares-ui#30 - creating recurring payments in private testnet to test api calls as there is almost no public operations of this kind. ill extend a bit the documentation available with some simulated recurring payments examples as i was not able to find anything of value except for that link and https://bitshares.org/technology/recurring-and-scheduled-payments/ . Too little for such an important feature IMO.

@oxarbitrage
Copy link
Member

closed by #676

@abitmore abitmore modified the milestones: Future Non-Consensus-Changing Release, 201803 Non-Consensus-Changing Release Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants