Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the "Private testnet howto" documentation #700

Closed
RuneStone0 opened this issue Mar 6, 2018 · 4 comments
Closed

Minor improvements to the "Private testnet howto" documentation #700

RuneStone0 opened this issue Mar 6, 2018 · 4 comments

Comments

@RuneStone0
Copy link

RuneStone0 commented Mar 6, 2018

1) Missing = sign between input parameter and value
After following the documentation (http://docs.bitshares.org/testnet/private-testnet.html), I noticed several bugs. This was tested on Ubuntu. When running the following command:

witness_node --data-dir data

The "data" parameter is ignored and the default "witness_node_data_dir" was used instead, causing some confusion. To solve this add an equal sign:

witness_node --data-dir=data

I suggest the documentation is updated to be more consistent, so all input parameter/values are illustrated using param=value.

2) Confusing config.ini configuration and cli_wallet end-point used
I suggest the following changes to config.ini (use port 8090 instead of 11011):

rpc-endpoint = 127.0.0.1:8090
genesis-json = my-genesis.json
enable-stale-production = true

To me it was a bit confusing that the suggested rpc-endpoint port number was 11011 (which is the default port for the p2p network). To avoid this confusion, lets use :8090 instead? This will make it more aligned when the rest of the documentation, when cli_wallet connects to a witness end-point.

@abitmore
Copy link
Member

abitmore commented Mar 6, 2018

  1. Missing = sign between input parameter and value

This is due to a bug of a boost 1.60. If you compile with boost 1.58, the = sign can be omitted.

rpc-endpoint port number was 11011

Contributions are appreciated. Best if you can submit a pull request.

@abitmore
Copy link
Member

abitmore commented Mar 6, 2018

Please submit PR against the docs repository. The source file is here. Closing this one.

@abitmore
Copy link
Member

abitmore commented Mar 6, 2018

Forwarded here: bitshares/docs.bitshares.org#51

@cedar-book
Copy link

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants