Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build BitShares-Core Linux binaries with Ubuntu 18.04 LTS (Bionic Beaver) #51

Merged
merged 3 commits into from
Oct 31, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Oct 29, 2021

Build BitShares-Core Linux binaries with Ubuntu 18.04 LTS (Bionic Beaver) and bump versions of OpenSSL and curl libraries.

Fixes #49.

and bump versions of OpenSSL and curl libraries
@abitmore abitmore added this to the bitshares-core release 6.0.0 milestone Oct 29, 2021
@abitmore abitmore changed the title Build BitShares-Core Linux binaries with Ubuntu 18 Build BitShares-Core Linux binaries with Ubuntu 18.04 LTS (Bionic Beaver) Oct 29, 2021
@abitmore
Copy link
Member Author

abitmore commented Oct 30, 2021

test-6.0.0 fails to build with OSX cross-build:

Undefined symbols for architecture x86_64:
  "_CFRelease", referenced from:
      _Curl_resolv in libcurl.a(libcurl_la-hostip.o)
  "_SCDynamicStoreCopyProxies", referenced from:
      _Curl_resolv in libcurl.a(libcurl_la-hostip.o)
ld: symbol(s) not found for architecture x86_64

Related code in curl: https://github.com/curl/curl/blob/curl-7_79_1/lib/hostip.c#L667-L669

#if defined(ENABLE_IPV6) && defined(CURL_OSX_CALL_COPYPROXIES)
    {
      /*
       * The automagic conversion from IPv4 literals to IPv6 literals only
       * works if the SCDynamicStoreCopyProxies system function gets called
       * first. As Curl currently doesn't support system-wide HTTP proxies, we
       * therefore don't use any value this function might return.
       *
       * This function is only available on a macOS and is not needed for
       * IPv4-only builds, hence the conditions above.
       */
      CFDictionaryRef dict = SCDynamicStoreCopyProxies(NULL);
      if(dict)
        CFRelease(dict);
    }
#endif

@abitmore
Copy link
Member Author

The error was caused by a recent change (and follow-ups) in curl which meant to support "NAT64 address synthesis" in macOS, introduced since curl 7.77.0: curl/curl@31f631a

It made the "SystemConfiguration framework" a dependency for curl mac build. We do have the framework in SDK, so it compiles fine. But we didn't link with it. Since we only link libraries statically, I'm not sure what's the best way to link with the framework.

The new code exists only when IPv6 support is enabled when building curl (which is enabled by default). If we disable IPv6 support in macOS build, we do not need to link with the framework.

Another option is to revert to an older version of curl.

@abitmore
Copy link
Member Author

Decided to build macOS binaries with an older curl version (7.76.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Ubuntu 16.04
1 participant