Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[~8] Provide easy way to add custom templates for Style Guide #1925

Closed
3 tasks
gibbsfromncis opened this issue Oct 3, 2018 · 5 comments
Closed
3 tasks

[~8] Provide easy way to add custom templates for Style Guide #1925

gibbsfromncis opened this issue Oct 3, 2018 · 5 comments

Comments

@gibbsfromncis
Copy link
Contributor

For now if any user wants to create his own theme for Reference Wallet it was possible to do within Reference Wallet fork.

But when we start to work with Style Guide this ability was broken because if user of Reference Wallet start to use his own theme with different name like "myCustomTheme" all Style Guide components become broken.

The idea is to architect and provide an instruction how developers can create and use their custom themes.

  • Remove hardcode of 3 themes inside Style Guide Project
  • Provide an ability to easily manage available Style-Guide themes with custom names also
  • Instruction how to easily manage/use Style-Guide themes

Requested estimate: 8h

@wmbutler @startailcoon it's a little bit hard to estimate this issue because there are situations I have no idea how I'm going to solve before I start to work on this. I hope 8h is fair estimate and it's enough.

@gibbsfromncis gibbsfromncis added the [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks label Oct 3, 2018
@gibbsfromncis gibbsfromncis self-assigned this Oct 3, 2018
@gibbsfromncis gibbsfromncis added this to Backlog in Issue Triage via automation Oct 3, 2018
@sschiessl-bcp
Copy link
Contributor

I'm all for leveraging community created styles! Enhances the "us" feeling.

Continues the vision from #1613 (comment)

@startailcoon
Copy link
Contributor

This would be a nice thing. Acknowledge that estimated hours are rough and can change. It's a task that needs to take its time

@gibbsfromncis gibbsfromncis added this to the 181017 milestone Oct 3, 2018
@gibbsfromncis
Copy link
Contributor Author

@startailcoon I'll put it to next milestone if you agree.

@startailcoon startailcoon changed the title Provide easy way to add custom templates for Style Guide [~8] Provide easy way to add custom templates for Style Guide Oct 3, 2018
@startailcoon startailcoon added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) and removed [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks labels Oct 13, 2018
@gibbsfromncis gibbsfromncis modified the milestones: 181017, 181031 Oct 13, 2018
@gibbsfromncis gibbsfromncis modified the milestones: 181031, 181114 Nov 5, 2018
@wmbutler wmbutler modified the milestones: 181114, 190103 Nov 18, 2018
@startailcoon startailcoon modified the milestones: 190103, 190327 Feb 14, 2019
@gibbsfromncis gibbsfromncis removed the [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) label Mar 12, 2019
@gibbsfromncis gibbsfromncis removed their assignment Mar 12, 2019
@gibbsfromncis gibbsfromncis removed this from the 190329 milestone Mar 12, 2019
@sschiessl-bcp
Copy link
Contributor

Please add a reason for closure. I assume due to redesign?

@gibbsfromncis
Copy link
Contributor Author

@sschiessl-bcp because I'll rethink how style-guide works when we start redesign, you're correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants