Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Replace Market Picker #1975

Closed
2 tasks
gibbsfromncis opened this issue Oct 10, 2018 · 11 comments
Closed
2 tasks

[3] Replace Market Picker #1975

gibbsfromncis opened this issue Oct 10, 2018 · 11 comments
Assignees
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Needs Discussion More discussion is required before implemented or worked on [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone

Comments

@gibbsfromncis
Copy link
Contributor

screenshot 2018-10-10 05 05 06

Market Picker opens on the left panel like a dropdown and looks terrible.

Todo:

  • Replace it for Modal
  • Make more usable
@gibbsfromncis gibbsfromncis added the [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks label Oct 10, 2018
@gibbsfromncis gibbsfromncis self-assigned this Oct 10, 2018
@sschiessl-bcp
Copy link
Contributor

I like it to be a non-intrusive layover instead of a model. Any ideas to keep the layover but make it pretty?

@gibbsfromncis
Copy link
Contributor Author

gibbsfromncis commented Oct 11, 2018

@sschiessl-bcp What do you think about Drawer component from ant ?

I suppose it should fit your requirements/preferences well

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Oct 11, 2018

Can drawers be configured to not take the whole height of the screen?

Ideally (IMO) the drawer would still begin where it begins now and have size that correlates to chart height + margin (which is a settings option)
image

@froooze
Copy link
Collaborator

froooze commented Nov 7, 2018

  • Do we need the different Modes? What is the difference?
  • Can we use the searchbox from Explore -> Witnesses ?

@gibbsfromncis gibbsfromncis removed their assignment Nov 7, 2018
@gibbsfromncis
Copy link
Contributor Author

I've unassigned myself because I have no time for this task and it requires additional discussion.

@startailcoon @sschiessl-bcp can you please put your thoughts/requirements so anyone else can take it

@sschiessl-bcp
Copy link
Contributor

It has been ANTified
image

Remaining question is the modes. Can search do anything filter can't?

@gibbsfromncis
Copy link
Contributor Author

@sschiessl-bcp no idea. I'll check it

@gibbsfromncis gibbsfromncis self-assigned this Nov 15, 2018
@gibbsfromncis gibbsfromncis added this to the 181128 milestone Nov 15, 2018
@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [2] Needs Discussion More discussion is required before implemented or worked on [5c] Medium Indicates size of task. Est. between two and four hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Nov 20, 2018
@startailcoon startailcoon changed the title Replace Market Picker [3] Replace Market Picker Nov 20, 2018
@startailcoon
Copy link
Contributor

Regarding "Search" and "Find" differences, view the original issue here #1379

@wmbutler wmbutler modified the milestones: 181128, 181212 Dec 1, 2018
@wmbutler wmbutler assigned wmbutler and unassigned gibbsfromncis Dec 15, 2018
@wmbutler
Copy link
Contributor

Let me take a shot at UX @gibbsfromncis

@wmbutler
Copy link
Contributor

wmbutler commented Dec 18, 2018

Observations:

  • It would be best to have only 1 option for picking a market. We currently have search and filter. Simply remove the option and let's follow the rules below.
  • All bitassets must be searchable and be prioritized regardless of using USD or bitUSD, etc.
  • Issuer should be displayed in the list after a user has filtered for an asset
  • Filter should act on the entire beginning part of the asset (case insensitive) with stipulations shown below.

btc would find the assets open.btc, btc.btc, bitbtc, bridge.btc and would display in this priority:

  1. bitbtc - because it's a bit asset committee account
  2. bridge.btc - because the symbol is an exact match on the asset name after the dot and the filter contains no dot and because alphabetically bridge comes before open
  3. btc.btc because alphabetically btc comes before open
  4. open.btc
  • Assets matching after the . should be prioritized first if the filter does not contain a .

If a user does not type a . in their filter, attempt match on only the text after the .

  • Assets matching from the very beginning should be prioritized if the filter contains a .

If a user's typed filter contains a ., you must search the asset from the very beginning and prioritized based on the match.

  • Filter should work every time (there is a bug preventing this currently)

  • We can safely remove the "use" button and the "OK" and "Save" buttons because picking the asset will assume SAVE and an off-click will assume CANCEL

screen shot 2018-12-17 at 7 56 34 pm

@gibbsfromncis
Copy link
Contributor Author

@wmbutler I've created new task for implementation to close this task to do not ask you to wait for UI to be billed.

@twksos twksos mentioned this issue Apr 15, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Needs Discussion More discussion is required before implemented or worked on [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

No branches or pull requests

5 participants