Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign any message with any account key #233

Closed
xeroc opened this issue Aug 9, 2017 · 4 comments
Closed

Sign any message with any account key #233

xeroc opened this issue Aug 9, 2017 · 4 comments
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone
171121

Comments

@xeroc
Copy link
Member

xeroc commented Aug 9, 2017 •
edited
Loading

I would like to have a feature that allows the wallet to sign any message with any key in the wallet.
Ideally, this can be used to prove ownership of an account.
The page would have these input fields

  • message
  • key (list accounts, then pick from active, owner, memo - if pressent ... or pick other key to list all known keys in the wallet)
  • signature (signature for the message)

I would recommend to use the same syntax that bitcoin uses which looks like this:

-----BEGIN BITCOIN SIGNED MESSAGE-----
This is an example of a signed message.asfasf
-----BEGIN BITCOIN SIGNATURE-----
Version: Bitcoin-qt (1.0)
Address: 1HZwkjkeaoZfTSaJxDw6aKkxp45agDiEzN

G7uxfdHRjFEpnvcv+m4HUg0dUwWIjmpJ6wI3DjaU8/Kcb9CZOLF9JUfBUtav8SUjm5bnxQPsbM4fHyW1rui/DMc=
-----END BITCOIN SIGNATURE-----

Except that we should use a public key instead of an address .. like this:

-----BEGIN BITCOIN SIGNED MESSAGE-----
This is an example of a signed message.asfasf
-----BEGIN BITCOIN SIGNATURE-----
Chain: BitShares
Account: xeroc
Publickey: BTS5TPTziKkLexhVKsQKtSpo4bAv5RnB8oXcG4sMHEwCcTf3r7dqE

G7uxfdHRjFEpnvcv+m4HUg0dUwWIjmpJ6wI3DjaU8/Kcb9CZOLF9JUfBUtav8SUjm5bnxQPsbM4fHyW1rui/DMc=
-----END BITCOIN SIGNATURE-----
@xeroc xeroc added the [3] Feature Classification indicating the addition of novel functionality to the design label Aug 9, 2017
@btsfav
Copy link

btsfav commented Aug 9, 2017

yes, please!

@wmbutler wmbutler added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation and removed [3] Feature Classification indicating the addition of novel functionality to the design labels Aug 10, 2017
@wmbutler wmbutler changed the title [feature request] Sign any message with any account key Sign any message with any account key Aug 10, 2017
@btsfav
Copy link

btsfav commented Oct 16, 2017

can this be pushed?

@wmbutler wmbutler added this to the 171201 milestone Oct 16, 2017
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Oct 16, 2017
@btsfav btsfav mentioned this issue Nov 4, 2017
Closed
3 tasks
@wmbutler wmbutler modified the milestones: 171201, 171215 Nov 5, 2017
@calvinfroedge
Copy link
Contributor

@xeroc Does this just generate a message you'd then copy paste with the signature?

@btsfav
Copy link

btsfav commented Nov 27, 2017

@calvinfroedge feature is implemented since last update

@wmbutler wmbutler modified the milestones: 171215, 171121 Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Milestone
171121
Development

No branches or pull requests
4 participants
@xeroc @calvinfroedge @wmbutler @btsfav