Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5][dot5enko] Add support for market fee sharing #2594

Closed
6 tasks
abitmore opened this issue Apr 6, 2019 · 9 comments · Fixed by #2737
Closed
6 tasks

[2.5][dot5enko] Add support for market fee sharing #2594

abitmore opened this issue Apr 6, 2019 · 9 comments · Fixed by #2737
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Feature Classification indicating the addition of novel functionality to the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Finalized Administartion flag, notifies hours are finalized
Projects
190618 Release
Milestone
190607

Comments

@abitmore
Copy link
Member

abitmore commented Apr 6, 2019 •
edited

Is your feature request related to a problem? Please describe.

extensions field of asset_options has a new type in bitshares-core 3.0.0: https://github.com/bitshares/bitshares-core/blob/3.0.0/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp#L85, we need to

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@startailcoon startailcoon added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Feature Classification indicating the addition of novel functionality to the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Apr 7, 2019
@startailcoon startailcoon added this to the 190426 milestone Apr 7, 2019
@startailcoon startailcoon changed the title Add support for market fee sharing [2] Add support for market fee sharing Apr 7, 2019
@startailcoon startailcoon changed the title [2] Add support for market fee sharing [1] Add support for market fee sharing Apr 7, 2019
@startailcoon startailcoon added [0] BLOCKED Notification to UI Team that Assignee is unable to proceed. Need impediment removed. and removed [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Feature Classification indicating the addition of novel functionality to the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Apr 7, 2019
@startailcoon
Copy link
Contributor

Blocked By bitshares/bitsharesjs#45

@startailcoon startailcoon added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Feature Classification indicating the addition of novel functionality to the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Apr 7, 2019
@dot5enko
Copy link
Contributor

dot5enko commented Apr 23, 2019 •
edited

@sschiessl-bcp as i've took related bitsharesjs issue i'll handle this too

@startailcoon startailcoon changed the title [1] Add support for market fee sharing [1][dot5enko] Add support for market fee sharing Apr 28, 2019
@startailcoon startailcoon modified the milestones: 190426, 190510 Apr 28, 2019
@startailcoon startailcoon modified the milestones: 190510, 190524 May 12, 2019
@sschiessl-bcp
Copy link
Contributor

Available in bitsharesjs@3.0.0-rc4

@startailcoon startailcoon modified the milestones: 190524, 190607 May 26, 2019
@startailcoon
Copy link
Contributor

Ping @dot5enko

@startailcoon startailcoon removed the [0] BLOCKED Notification to UI Team that Assignee is unable to proceed. Need impediment removed. label May 26, 2019
@dot5enko
Copy link
Contributor

@startailcoon still work in progress

@sschiessl-bcp
Copy link
Contributor

Work faster!

@dot5enko
Copy link
Contributor

@sschiessl-bcp for some reason Available in bitsharesjs@3.0.0-rc4 not contains that serialization in it.

@dot5enko dot5enko mentioned this issue Jun 1, 2019
Merged
@dot5enko
Copy link
Contributor

dot5enko commented Jun 4, 2019

@startailcoon can we adjust the bounty to 2.5h? it was a lot of investigation and stuff needed cause asset create/update components are a little bit hardcoded/copypasted. Also bitsahresjs was a little bit fixed bitshares/bitsharesjs#52 in collaboration with @sschiessl-bcp

@sschiessl-bcp sschiessl-bcp added this to To do in 190618 Release via automation Jun 5, 2019
@sschiessl-bcp sschiessl-bcp moved this from To do to Done in 190618 Release Jun 6, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Jun 9, 2019
Closed
@sschiessl-bcp sschiessl-bcp moved this from Done to Added to notes in 190618 Release Jun 11, 2019
@startailcoon startailcoon changed the title [1][dot5enko] Add support for market fee sharing [2.5][dot5enko] Add support for market fee sharing Jun 18, 2019
@startailcoon
Copy link
Contributor

can we adjust the bounty to 2.5h?

Adjusted

190618 Release automation moved this from Added to notes to Done Jun 27, 2019
@clockworkgr clockworkgr added [7] Finalized Administartion flag, notifies hours are finalized and removed [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Feature Classification indicating the addition of novel functionality to the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Finalized Administartion flag, notifies hours are finalized
Projects
No open projects
190618 Release
  
In Release
Milestone
190607
Development

Successfully merging a pull request may close this issue.

2594 add market fee sharing
5 participants
@dot5enko @clockworkgr @abitmore @startailcoon @sschiessl-bcp