Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0] Can't update TCR #2785

Closed
froooze opened this issue Jun 17, 2019 · 5 comments · Fixed by #2787
Closed

[0] Can't update TCR #2785

froooze opened this issue Jun 17, 2019 · 5 comments · Fixed by #2787
Assignees
@startailcoon
Labels
[6] RC Blockage Impact flag identifying UI Release Candidate blockage [7] Finalized Administartion flag, notifies hours are finalized
Projects
190618 Release
Milestone
190607

Comments

@froooze
Copy link
Collaborator

froooze commented Jun 17, 2019 •
edited

Describe the bug
Updating only the TCR leads to an error

To Reproduce
Steps to reproduce the behavior:

  1. Go to margin positions
  2. Change TCR
  3. Save
  4. See error

Expected behavior
Allow TCR change without changing debt or collateral

Screenshots
margin-position-failed

Desktop (please complete the following information):

  • OS: MX-Linux
  • Version: 3.1.190618-rc1-rc1

Additional context
I looked for delta_collateral.amount and delta_debt.amount but did not find any logic for this.
@sschiessl-bcp sschiessl-bcp added the [6] RC Blockage Impact flag identifying UI Release Candidate blockage label Jun 17, 2019
@sschiessl-bcp
Copy link
Contributor

Needs validation

@startailcoon
Copy link
Contributor

startailcoon commented Jun 17, 2019 •
edited

Not possible. Either collateral or debt has to change. This is a core limitation.

If no change is made, but TCR does, we should change collateral with +1 of the lowest precision unit of the collateral asset.

@froooze
Copy link
Collaborator Author

froooze commented Jun 17, 2019 •
edited

Not possible. Either collateral or debt has to change. This is a core limitation.

Therefore, I did not found an logic for this on UI.

If no change is made, but TCR does, we should change collateral with +1 of the lowest precision unit of the collateral asset.

This would be a quick fix from the UI!

@startailcoon
Copy link
Contributor

Will fix this to enable near zero collateral change when it's not done by the user.

@startailcoon startailcoon self-assigned this Jun 17, 2019
@startailcoon startailcoon added this to the 190621 milestone Jun 17, 2019
@abitmore
Copy link
Member

It's a core "feature".

@startailcoon startailcoon changed the title Can't update TCR [0] Can't update TCR Jun 17, 2019
@startailcoon startailcoon mentioned this issue Jun 17, 2019
Merged
@sschiessl-bcp sschiessl-bcp added this to To do in 190618 Release via automation Jun 18, 2019
190618 Release automation moved this from To do to Done Jun 18, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 190621, 190607 Jun 18, 2019
@sschiessl-bcp sschiessl-bcp moved this from Done to Added to notes in 190618 Release Jun 25, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Jun 25, 2019
Closed
@froooze froooze mentioned this issue Jun 27, 2019
Closed
12 tasks
190618 Release automation moved this from Added to notes to Done Jun 27, 2019
@clockworkgr clockworkgr added the [7] Finalized Administartion flag, notifies hours are finalized label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startailcoon startailcoon

Labels
[6] RC Blockage Impact flag identifying UI Release Candidate blockage [7] Finalized Administartion flag, notifies hours are finalized
Projects
No open projects
190618 Release
  
In Release
Milestone
190607
Development

Successfully merging a pull request may close this issue.

Issue 2785 - Enable TCR Margin only Update bitshares/bitshares-ui
5 participants
@clockworkgr @abitmore @startailcoon @sschiessl-bcp @froooze