Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Notify users about available update in the wallet #43

Closed
svk31 opened this issue Jan 19, 2017 · 5 comments
Closed

[4] Notify users about available update in the wallet #43

svk31 opened this issue Jan 19, 2017 · 5 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive
Milestone

Comments

@svk31
Copy link
Contributor

svk31 commented Jan 19, 2017

From @btswolf on March 9, 2016 16:7

If there is a new public release of the light wallet there should be an indicator that a newer version is available. Could be at the bottom. Update available.... outdated etc...

Copied from original issue: cryptonomex/graphene-ui#765

@wmbutler
Copy link
Contributor

Agreed. The client needs to be able to report this only after the binaries are in place. To enhance this further, the client would initiate the download and self-update once the user agrees.

@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Jul 21, 2017
@wmbutler
Copy link
Contributor

This isn't pixel perfect, but the idea here is that the cloud download icon would open an external browser to reveal: https://bitshares.org/download/

This is a screenshot of the lower left corner of the Bitshares light wallet when it has detected that there is an update that can be downloaded by the user. It's important that the notification detect an actual downloadable binary. If we don't do that, it's possible that we would release a new version and the end user would be unable to locate a binary if it hadn't yet been built.

screen shot 2017-07-30 at 6 57 48 pm

@testlump
Copy link

testlump commented Aug 4, 2017

The development should take into account differing releases of the UI. For example RuDEX create their own builds based off of the bitshares-ui core repository.

Basic security features such as possibly signing update notification alerts should be implemented alongside ways to ensure differing UI releases can easily override signing keys (possibly global constant?) to provide their own notification channels to their users (E.g. RuDEX UI builds).

A hyperlink to the download page would also be helpful but only if it poses no risk of manipulation by malicious actors. In may be easier to place this into the settings menu and just have a "Get Latest Release" hyperlink and hardcode the URI into the build.

@wmbutler
Copy link
Contributor

wmbutler commented Aug 4, 2017

I'd suggest that RuDEX create their own notification system. They can fork this REPO and follow our lead if they decide to.

@wmbutler wmbutler added this to the 170914 milestone Aug 18, 2017
@wmbutler wmbutler added the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Aug 18, 2017
@calvinfroedge calvinfroedge self-assigned this Sep 1, 2017
@calvinfroedge calvinfroedge changed the title Nofify users about available update in the wallet [2] Nofify users about available update in the wallet Sep 1, 2017
@wmbutler
Copy link
Contributor

If update is available display:

  • cloud download icon
  • update available text

If update is not available, just display the version number.

@calvinfroedge calvinfroedge changed the title [2] Nofify users about available update in the wallet [4] Nofify users about available update in the wallet Sep 12, 2017
@calvinfroedge calvinfroedge changed the title [4] Nofify users about available update in the wallet [4] Notify users about available update in the wallet Sep 12, 2017
@svk31 svk31 closed this as completed Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive
Projects
None yet
Development

No branches or pull requests

4 participants