wallets_record_repair seems buggy

[xeroc]

I made an update to the latest git-head 1854346

Upgrading wallet...                                                                                                                                                                                                 
Backing up wallet...                                                                    
Wallet automatically backed up to: /home/--censored--
Please unlock your wallet to complete the upgrade...                                    
Continuing wallet upgrade...                                                                                                                                                                                        
Wallet records repaired.
Wallet successfully upgraded.   

Result:

2014-11-10T13:44:50 973225    payouts.xeroc       BTS9LGHWFqt7GyUj... 75,057.83999 BTS        ^??|???,?v?%?q?f                         14,438.25833 BTS        0.50000 BTS         047d2ba0
2014-11-11T02:52:00 977944    payouts.xeroc       BTS6uhQ4dzAXnhLS... 34,650.00000 BTS        ?:???C???/!c??                         14,437.75833 BTS        0.50000 BTS         9b54afa7
2014-11-11T06:40:00 979309    payouts.xeroc       BTS76dBwJudKxrNs... 69,300.00000 BTS       ?e?L?L'!?CC???MF                         14,437.25833 BTS        0.50000 BTS         babce03f

Not even the numbers are correct here :(

The wallet is currently doing a resync.. and more and more transactions are added to the "history" though they have not been made since the last sync

[xeroc]

I also lost some (private) keys from "wallet_account_list_public_keys" after the upgrade ..
Could only recover by downgrading to an older (v0.4.24) client version and import a backup ..

[vikramrajkumar]

The following are likely related:

• Is this how should look transaction history? #1071
• wallets_record_repair seems buggy #1075
• transaction to address not found by rescan #1080

[vikramrajkumar]

@xeroc are you absolutely sure that you were using 1854346? The bitshares_toolkit_revision in the output of about should tell you for sure.

This looks similar to #1071, which was a bug in both develop and bitshares branches, but should not be in master.

[vikramrajkumar]

@xeroc, regardless of the answer to the above question, it would be helpful if you could test on the latest bitshares branch (use 26ac1c5) and let us know if they are still producible. In addition to the previously mentioned scanning fix, wallet_repair_records has also been improved and the two issues should hopefully not occur in the latest version.

I recommend testing with a fresh throwaway data-directory and wallet--the latest bitshares branch has an upgraded LevelDB and you will not be able to downgrade the chain and wallet database files to work with the previous release.

[xeroc]

@vikramrajkumar
can't verify the commit anymore .. I had to downgrade the system as I use it to publish feeds .. sorry mate

I will test on the latest commits.. I noticed the non-down-gradable leveldb already :)

[xeroc]

@vikramrajkumar
This issue seems to be resolved .. couldn't reproduce

however issue #1080 is still not resolved