Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP#27: Asset Issuer Reclaim Fee Pool Funds #36

Closed
abitmore opened this issue Nov 2, 2017 · 1 comment
Closed

BSIP#27: Asset Issuer Reclaim Fee Pool Funds #36

abitmore opened this issue Nov 2, 2017 · 1 comment

Comments

@abitmore
Copy link
Member

abitmore commented Nov 2, 2017

BSIP: 0027
Title: Asset Issuer Reclaim Fee Pool Funds
Authors: Abit More <https://github.com/abitmore>
         Fabian Schuh <Fabian@BitShares.eu>
Status: Draft
Type: Protocol
Created: 2017-11-02
Discussion: https://github.com/bitshares/bitshares-core/issues/188
Worker: TBD

Abstract

Asset issuers need a way to get out some CORE assets (BTS) from their assets' fee pool, for example when accidentally filled too much BTS into the pool. As of writing, this can be done by crafting a special limit order then cancel it, the process is a bit complicated. In addition, this approach will no longer work if BSIP #26 (Refund Order Creation Fee in Originally Paid Asset on Cancel) is implemented. This BSIP proposes a protocol change to meet the demand.

Motivation

Make the asset system easier to use.

Rational

Asset issuer should have full and easy control over the funds in the fee pool.

Specifications

Current Design and Implementation

Asset issuers can fill the fee pool with the asset_fund_fee_pool_operation operation, which has a structure as follows:

   struct asset_fund_fee_pool_operation : public base_operation
   {
      asset           fee; ///< core asset
      account_id_type from_account;
      asset_id_type   asset_id;
      share_type      amount; ///< core asset
      extensions_type extensions;
   };

The amount in the structure can only be positive, which means the from_account can only add some CORE asset (BTS) into an asset's fee pool.

Proposed Changes

  • Allow amount to be negative;
  • When amount is negative, from_account can only be the issuer;
  • When amount is negative, deduct the absolute amount from the asset's fee pool and add it to the issuer's balance.

Discussion

The operation fee for asset_fund_fee_pool_operation should be no less than transfer_operation.

Summary for Shareholders

[to be added]

Copyright

This document is placed in the public domain.

See Also

@abitmore abitmore changed the title New BSIP: Asset Issuer Reclaim Fee Pool Funds BSIP#27: Asset Issuer Reclaim Fee Pool Funds Nov 11, 2017
@abitmore
Copy link
Member Author

Added to master branch, closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant