Methods to clamp vector length #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Yeah there is a big refactor going on. I might be working on that for some time. It's probably easier if I apply changes to that branch myself since it's still a work in progress. |
bitshifter
requested changes
Nov 30, 2020
|
@CleanCut I've merged the big refactor back to master. If you want to update this PR, you can add the methods once to the |
CleanCut
added a commit
to CleanCut/glam-rs
that referenced
this pull request
Jan 17, 2021
|
Closing in favor of #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of
clamp_length*methods forVec2,Vec3,Vec3A, andVec4.This PR is based off of
0.11.0, but I can see that there is a pretty heavy refactor going on in therefactorbranch to produce theVec*implementations through macros. I'm willing to reimplement this PR off ofrefactorif that's helpful. (probably after it's in a stable state?)Resolves #100