-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Borsh serializer support #322
Conversation
Hi there, I prefer it if people create a discussion to ask if new features are wanted to avoid wasting anyone's time, see https://github.com/bitshifter/glam-rs/blob/main/CONTRIBUTING.md#new-functions-and-methods. I should really make a pull request template because no one reads CONTRIBUTING in my experience. Also with a PR it's good to leave a comment saying what the PR is for and why it would benefit glam users. In this case of this crate, I don't want to add support for it for a few reasons:
Hopefully at some stage the orphan rule will be relaxed and it will be easier to implement traits without needing newtypes, at which point there will be less burden on crate maintainers to add support for many many different crates. |
borsh is he only one having enums be 1 byte, i tried 5 different crates. (bincode, postcard, rykv, speedy, borsh) |
my code that i offered is fairly straight forward, and it just works. no need to do anything else |
Maybe forks like these could be referenced in the Readme file to make them easier to find? I'm currently adding |
No description provided.