This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Feedback window minor bugs fixed #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmourat, |
lumaxis
reviewed
Apr 12, 2017
|
|
||
| // Since we are mutating array we need to go backwards | ||
| for(NSView *subview in [self.subviews reverseObjectEnumerator]){ | ||
| if([subview isKindOfClass:[BITActivityIndicatorButton class]]){ |
There was a problem hiding this comment.
I think there are a couple of spaces missing here? 🙂
| @@ -353,8 +353,10 @@ - (BOOL)canSendMessage { | |||
| } | |||
|
|
|||
| - (IBAction)sendMessage:(id)sender { | |||
| [self.manager submitMessageWithText:[self.messageText string] andAttachments:self.attachments]; | |||
| [self.manager submitMessageWithText:[self.messageText string] andAttachments:[[NSArray alloc] initWithArray:self.attachments]]; | |||
There was a problem hiding this comment.
If you want, a small syntax improvement could be to use [NSArray arrayWithArray:self.attachments]; instead
| @@ -211,6 +212,15 @@ - (void)drawRect:(NSRect)dirtyRect { | |||
| [super drawRect:dirtyRect]; | |||
| } | |||
|
|
|||
| - (void)clearAllImageViews{ | |||
|
|
|||
| // Since we are mutating array we need to go backwards | |||
There was a problem hiding this comment.
a)mutating THE array -> full English sentences, please.
b) which array? Please be specific.
ElektrojungeAtWork
suggested changes
Apr 12, 2017
ElektrojungeAtWork
approved these changes
May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugs fixed:
Bug with recycling images in tableview cells
Bug with attachment list not being cleared after sending message