Programmatically attach files to feedback

[tonklon]

This is just a quick hack to demonstrate what I mean in #59 and get things going.

What is the best way the get the files to attach? In a delegate callback? Should the files only be attached on the first feedback?

Should the programmatically attached files show up in the UI? It could confuse the user.

[msftclas]

Hi @tonklon, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

[lumaxis]

Thanks a lot for these PRs @tonklon!

What is the best way the get the files to attach? In a delegate callback? Should the files only be attached on the first feedback?

As you might have seen, we have the logic to support this use case already in the iOS SDK. We wanted to port this over to the Mac SDK for a while now already but haven't gotten around to it yet so thanks again for helping speed this up :)
This is what the API currently looks like on iOS: https://github.com/bitstadium/HockeySDK-iOS/blob/bfb9101ca8a71bb0f4bd4a9036e61df04fc73b2d/Classes/BITFeedbackManager.h#L313-L323
I think we'll be fine with what you're proposing or at least something very similar.

Regarding having a delegate method for this: I've actually been thinking about adding a delegate for this to the iOS SDK and just opened a PR for that here: bitstadium/HockeySDK-iOS#269
We're still discussing how this should look in the future but I think it might make sense to have both. We're very open to opinions on this though!

Should the programmatically attached files show up in the UI? It could confuse the user.

On iOS, we do this but only for images, I think. What do you think, would you say that make sense for the Mac too?
Edit: This is what the logic for that looks like on iOS: https://github.com/bitstadium/HockeySDK-iOS/blob/bfb9101ca8a71bb0f4bd4a9036e61df04fc73b2d/Classes/BITFeedbackComposeViewController.m#L112-L145

[tonklon]

Ok, I will look into iOS and come up with a similar solution. That makes sense.

Speaking of a delegate, there is no such thing on the mac right now. So that would need some more work to do.

[ElektrojungeAtWork]

Hey guys,

We won't merge this any time soon. Closing this PR to reflect the current state of things.
We're looking into macOS support for Mobile Center but I can't give any other info than that.

Best,
Benny