This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Allow description longer than 32k #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecially Descripotion) values longer than 32k
|
Hi @schuettecarsten, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
I just saw that the same issue has been adressed in #35. Unfortunately, the bug is back. |
|
@schuettecarsten thank you for your contribution. |
|
Yes, will do soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a description is sent to the server, HockeySDK uses Uri.EscapeDataString() to escape it. Unfortunately, this method only supports 32k strongs (as written in MSDN, in fact it supports up to 64k), so longer descriptions cause in internal exception.
This PR adds UriExtensions.EscapeDataString and changes the usage of Uri.EscapeDataString to the new method.
Please review.
CLA signed.