Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pipeline code, no unnecessary install of wheel package #77

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

bittner
Copy link
Owner

@bittner bittner commented Nov 19, 2023

The python -m build command executed by Tox takes care of installing the wheel package, which is needed for building a wheel distribution from the source distribution package.

Hence, it's unnecessary to have the wheel package installed by the pipeline, explicitly. Even worse, it creates visual noise, which we want to avoid.

python -m pip install ... is the explicit form of pip install ... when several versions of Python are installed, including their installed version of Pip. If we don't need that type of control we can simply use pip install, which again avoids visual noise that the spectator needs to interpret.

@bittner bittner merged commit dfc4346 into main Nov 19, 2023
32 checks passed
@bittner bittner deleted the feature/simplify-pipeline-code branch November 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant