Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider pascal-cased . delimited keys as a single key #17

Merged
merged 1 commit into from
Feb 5, 2015

Conversation

stocks29
Copy link

@stocks29 stocks29 commented Dec 4, 2014

This commit (w/ tests) allows for the usage of Module.Names as keys.

This is related to #16

@bitwalker
Copy link
Owner

@stocks29 This is great, thanks!

@johnfoconnor Thoughts on this?

@yrashk
Copy link
Contributor

yrashk commented Feb 5, 2015

Anything holding off this PR?

@bitwalker
Copy link
Owner

@yrashk, no I was holding out for additional comments, but I think I'm going to go ahead and merge it

bitwalker added a commit that referenced this pull request Feb 5, 2015
consider pascal-cased . delimited keys as a single key
@bitwalker bitwalker merged commit cd735ea into bitwalker:master Feb 5, 2015
@bitwalker
Copy link
Owner

Pushed in release 0.13.0

@yrashk
Copy link
Contributor

yrashk commented Feb 5, 2015

Thanks!

On Fri, Feb 6, 2015 at 1:52 AM, Paul Schoenfelder notifications@github.com
wrote:

Pushed in release 0.13.0


Reply to this email directly or view it on GitHub
#17 (comment).

Y.
My company is hiring: https://trustatom.com/jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants