Interval.difference/2 removes one interval from another #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanl
force-pushed
the
nathanl/add-interval-difference
branch
from
ab7ff3e
to
c3a9bb5
Compare
nathanl
force-pushed
the
nathanl/add-interval-difference
branch
from
c3a9bb5
to
c2417d4
Compare
nathanl
commented
Oct 12, 2018
lib/interval/interval.ex
Outdated
| # |--- remove ---| | ||
| # | ||
| # |- original -| | ||
| # |- remove -| |
There was a problem hiding this comment.
I found these little textual graphs helpful to understand the cases and ensure I'd covered them all. If you don't like keeping them as comments, we can delete them.
There was a problem hiding this comment.
I'm a fan! To keep it simple though, I would make the illustrations part of the @doc with names classifying the operation performed (i.e. empties, no-op, trims start, trims end, and splits), and make the comments in the code refer to that name. This keeps the code compact, but improves the documentation, and gives maintainers a nice visual reference when changes are being proposed/made.
nathanl
force-pushed
the
nathanl/add-interval-difference
branch
from
c2417d4
to
a4014db
Compare
|
@bitwalker Updated - was this what you had in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add
Interval.difference/2to remove one interval from another. This is one of the functions discussed in #460Checklist