This repository has been archived by the owner on May 25, 2022. It is now read-only.
Fix/lock lowdb file #470
Merged
Fix/lock lowdb file #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisonbeck
approved these changes
Feb 10, 2022
MGibson1
added a commit
that referenced
this pull request
Feb 10, 2022
* Lock data.json while running * Await floating promises * Increase retry frequency and attempt count for lock file * tweak lock retry times (cherry picked from commit ee66405)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We're seeing strange malformed
data.jsonfiles during CLI testing. This attempts to fix by awaiting a lock on the lowdb data file.Also used tslint rule
no-floating-promisesto detect and await any floating promises in the client. Note: un-awaited promises may still exist in jslib.fixes bitwarden/clients#2733
Code changes
lockDbFilemethod to the base implementationTesting requirements
Attempt to cause db lock issues with long chains of
bwand repeated commands.Before you submit
npm run lint) (required)Draft reason
Going to see about testing before putting up for review.