Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move auth to app folder #5336

Merged
merged 3 commits into from
May 2, 2023
Merged

Move auth to app folder #5336

merged 3 commits into from
May 2, 2023

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented May 2, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Moves web auth folder inside the app folder

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@jlf0dev jlf0dev marked this pull request as ready for review May 2, 2023 19:47
@jlf0dev jlf0dev requested review from a team as code owners May 2, 2023 19:47
@jlf0dev jlf0dev requested a review from a team May 2, 2023 19:47
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for moving these!

@jlf0dev jlf0dev merged commit 2c51af1 into master May 2, 2023
22 checks passed
@jlf0dev jlf0dev deleted the move-auth-to-app-folder branch May 2, 2023 20:08
djsmith85 added a commit that referenced this pull request Jul 13, 2023
@djsmith85
Update web-path for team-auth-dev
e1f7f83 
With #5336 all files got moved to apps/web/src/app/auth, but CODEOWNERS still pointed to apps/web/src/auth
@djsmith85 djsmith85 mentioned this pull request Jul 13, 2023
Merged
djsmith85 added a commit that referenced this pull request Jul 13, 2023
@djsmith85
Update web-path for team-auth-dev (#5817)
afb6c86 
With #5336 all files got moved to apps/web/src/app/auth, but CODEOWNERS still pointed to apps/web/src/auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsmith85 djsmith85 djsmith85 approved these changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlf0dev @djsmith85 @JaredSnider-Bitwarden