Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-path for team-auth-dev #5817

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Update web-path for team-auth-dev #5817

merged 1 commit into from
Jul 13, 2023

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

team-leads-eng got asked for a review on #5810 which was caused by apps/web/src/app/auth/login/login-decryption-options/login-decryption-options.component.ts.

Realized the path in the CODEOWNERS must be wrong.

With #5336 all files got moved to apps/web/src/app/auth, but CODEOWNERS still pointed to apps/web/src/auth

Code changes

  • .github/CODEOWNERS: Update path

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

With #5336 all files got moved to apps/web/src/app/auth, but CODEOWNERS still pointed to apps/web/src/auth
@djsmith85 djsmith85 requested a review from a team as a code owner July 13, 2023 14:03
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 13, 2023
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Jul 13, 2023
@djsmith85 djsmith85 enabled auto-merge (squash) July 13, 2023 14:07
@djsmith85 djsmith85 merged commit afb6c86 into master Jul 13, 2023
8 of 11 checks passed
@djsmith85 djsmith85 deleted the update-codeowners-auth branch July 13, 2023 14:08
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details864229eb-cabf-4407-8e49-ff2a1ccc040d

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants