Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-4925] Implemented getPublicKey to follow WSC standards #6934

Merged
merged 5 commits into from
Nov 27, 2023
Merged

[PM-4925] Implemented getPublicKey to follow WSC standards #6934

merged 5 commits into from
Nov 27, 2023

Conversation

gbubemismith
Copy link
Member

@gbubemismith gbubemismith commented Nov 21, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This fixes the issue raised #6913 in adhering to W3C standards.

Code changes

  • libs/common/src/vault/services/fido2/fido2-authenticator.service.ts: Added a new variable pubKeyDer that returns the public key in DER SubjectPublicKeyInfo format.
  • apps/browser/src/vault/fido2/webauthn-utils.ts The getPublicKey function is updated to return in public key in DER SubjectPublicKeyInfo format.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Nov 21, 2023
@coroiu
Copy link
Contributor

coroiu commented Nov 21, 2023

I don't think SPKI is the correct key format

@bitwarden-bot
Copy link

bitwarden-bot commented Nov 21, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – b22b3a03-a6f5-48e4-8d99-afbcd7a4dcde

No New Or Fixed Issues Found

@gbubemismith gbubemismith marked this pull request as ready for review November 23, 2023 14:27
@gbubemismith gbubemismith requested a review from a team as a code owner November 23, 2023 14:27
@gbubemismith gbubemismith changed the title Implemented getPublicKey to follow WSC standards [PM-4925] Implemented getPublicKey to follow WSC standards Nov 23, 2023
coroiu
coroiu approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this seems to be exporting the same format as chrome, at least according to https://lapo.it/asn1js/

@gbubemismith gbubemismith removed the needs-qa Marks a PR as requiring QA approval label Nov 27, 2023
@gbubemismith gbubemismith merged commit 301142f into master Nov 27, 2023
57 of 59 checks passed
@gbubemismith gbubemismith deleted the vault/implement-getpublickey branch November 27, 2023 16:02
@trmartin4 trmartin4 linked an issue Nov 27, 2023 that may be closed by this pull request
Passkeys -> getPublicKey() function not implemented, passkeys feature not following W3C standards #6913
Closed
1 task
@trmartin4 trmartin4 mentioned this pull request Nov 27, 2023
Closed
1 task
quexten pushed a commit to quexten/clients that referenced this pull request Feb 10, 2024
@gbubemismith @quexten
[PM-4925] Implemented getPublicKey to follow WSC standards (bitwarden…
951103c 
…#6934)

* Implemented getPublicKey to follow WSC standards

* Renamed variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coroiu coroiu coroiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passkeys -> getPublicKey() function not implemented, passkeys feature not following W3C standards
3 participants
@gbubemismith @coroiu @bitwarden-bot