[PM-7541] Move Last Desktop Settings #9310
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method settings.component.ts: SettingsComponent.ngOnInit
- Primitive Obsession desktop-settings.service.ts
- Complex Method 66-move-final-desktop-settings.ts: MoveFinalDesktopSettingsMigrator.migrate
✅ Improving Code Health:
- Code Duplication state.service.ts 🔥
Annotations
Check warning on line 294 in apps/desktop/src/app/accounts/settings.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
SettingsComponent.ngOnInit already has high cyclomatic complexity, and now it increases in Lines of Code from 135 to 138. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 180 in apps/desktop/src/main.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
Main.constructor increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 1 in apps/desktop/src/platform/services/desktop-settings.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Primitive Obsession
In this module, 84.6% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in libs/common/src/platform/services/state.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Code Duplication
reduced similar code in: StateService.setEnableBrowserIntegration,StateService.setEnableBrowserIntegrationFingerprint,StateService.setMinimizeOnCopyToClipboard. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
MoveFinalDesktopSettingsMigrator.migrate has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.