Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7541] Move Last Desktop Settings #9310

Merged
merged 14 commits into from
Jun 6, 2024

Conversation

justindbaur
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We had 3 settings left to migrate to the desktop settings service, this allows us to delete StateService in the main process of desktop altogether (exciting!).

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@justindbaur justindbaur requested review from a team as code owners May 22, 2024 15:15
@justindbaur justindbaur requested a review from MGibson1 May 22, 2024 15:15
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes missing coverage. Please review.

Project coverage is 28.20%. Comparing base (7d12d1a) to head (4b4bdc1).

Files Patch % Lines
.../src/platform/services/desktop-settings.service.ts 0.00% 22 Missing ⚠️
apps/desktop/src/main/messaging.main.ts 0.00% 5 Missing ⚠️
apps/desktop/src/main.ts 0.00% 4 Missing ⚠️
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 3 Missing ⚠️
...s/desktop/src/services/native-messaging.service.ts 0.00% 3 Missing ⚠️
...tions/migrations/66-move-final-desktop-settings.ts 93.87% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9310      +/-   ##
==========================================
+ Coverage   28.15%   28.20%   +0.05%     
==========================================
  Files        2432     2433       +1     
  Lines       71601    71636      +35     
  Branches    13381    13392      +11     
==========================================
+ Hits        20161    20208      +47     
+ Misses      49849    49834      -15     
- Partials     1591     1594       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as off-topic.

MGibson1
MGibson1 previously approved these changes May 23, 2024
apps/desktop/src/main.ts Outdated Show resolved Hide resolved
apps/desktop/src/main/messaging.main.ts Outdated Show resolved Hide resolved
jprusik
jprusik previously approved these changes May 28, 2024
@justindbaur justindbaur dismissed stale reviews from jprusik and MGibson1 via 1cd4515 May 28, 2024 20:55
jprusik
jprusik previously approved these changes May 29, 2024
@justindbaur justindbaur requested a review from jprusik June 3, 2024 19:32
@justindbaur justindbaur removed the needs-qa Marks a PR as requiring QA approval label Jun 6, 2024
@justindbaur justindbaur merged commit ba3d210 into main Jun 6, 2024
64 of 66 checks passed
@justindbaur justindbaur deleted the ps/pm-7541/move-last-desktop-settings branch June 6, 2024 18:26
cyprain-okeke pushed a commit that referenced this pull request Jun 10, 2024
* Clone Initial Data In `runMigrator`

- When using test cases, mutating the input data causes problems.

* Migrate `minimizeOnCopy` & `browserIntegrationEnabled`

* Update From Main

* Move Fingerprint Setting

- No Migration Yet

* Add Fingerprint to Migrations

* Convert Messaging to `async`

* Switch to calling `Boolean` for Map Function

* Catch Errors

* Remove LogService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants