-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7541] Move Last Desktop Settings #9310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using test cases, mutating the input data causes problems.
- No Migration Yet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9310 +/- ##
==========================================
+ Coverage 28.15% 28.20% +0.05%
==========================================
Files 2432 2433 +1
Lines 71601 71636 +35
Branches 13381 13392 +11
==========================================
+ Hits 20161 20208 +47
+ Misses 49849 49834 -15
- Partials 1591 1594 +3 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
MGibson1
previously approved these changes
May 23, 2024
jprusik
previously approved these changes
May 28, 2024
jprusik
previously approved these changes
May 29, 2024
MGibson1
approved these changes
Jun 3, 2024
jprusik
approved these changes
Jun 6, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Clone Initial Data In `runMigrator` - When using test cases, mutating the input data causes problems. * Migrate `minimizeOnCopy` & `browserIntegrationEnabled` * Update From Main * Move Fingerprint Setting - No Migration Yet * Add Fingerprint to Migrations * Convert Messaging to `async` * Switch to calling `Boolean` for Map Function * Catch Errors * Remove LogService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We had 3 settings left to migrate to the desktop settings service, this allows us to delete
StateService
in the main process of desktop altogether (exciting!).Before you submit