Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dotnet-format tool #1737

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Add dotnet-format tool #1737

merged 4 commits into from
Apr 26, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 31, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

Adds required configuration to run dotnet format. Since we are primarily using .NET 5, we rely on the tool variant, in the future the format command is baked into dotnet.

dotnet tool restore to install the tools.
dotnet tool run dotnet-format to apply the formatting rules

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@mpbw2 mpbw2 added the hold do not merge yet label Jan 31, 2022
@joseph-flinn
Copy link
Contributor

@Hinton The pipeline stuff looks good to me. I'll let @mportune-bw approve the rest.

@Hinton Hinton marked this pull request as ready for review April 26, 2022 13:05
@Hinton Hinton removed the hold do not merge yet label Apr 26, 2022
@Hinton Hinton merged commit e0efcfb into master Apr 26, 2022
@Hinton Hinton deleted the feature/format branch April 26, 2022 15:21
fedemkr added a commit that referenced this pull request Apr 28, 2022
@fedemkr
Merge branch 'master' into PS-77-fix-2fa-new-devices-resend
a1bf9d7 
* master:
  Bumped version to 2.18.1 (#1894)
  Bumped version to 2.18.0 (#1893)
  Update .gitattributes to fix build issue (#1892)
  [TI-8] Add .git-blame-ignore-revs (#1891)
  Run dotnet format (#1738)
  Add dotnet-format tool (#1737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpbw2 mpbw2 mpbw2 approved these changes

@joseph-flinn joseph-flinn Awaiting requested review from joseph-flinn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @joseph-flinn @mpbw2