Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-2116] ✨ feat(Support): Add Lemur Browser #2262

Merged
merged 4 commits into from
Dec 30, 2022
Merged

[PS-2116] ✨ feat(Support): Add Lemur Browser #2262

merged 4 commits into from
Dec 30, 2022

Conversation

Kevinlinpr
Copy link
Mannequin

@Kevinlinpr Kevinlinpr mannequin commented Dec 25, 2022

Lemur Browser is the mobile browser support Chrome and Edge extensions, build from chromium.

πŸ”— issue - #2260 πŸ”— Lemur Browser - https://www.lemurbrowser.com/

Objective

Support Lemur Browser

Code changes

1.AccessibilityHelpers.cs - add the new Browser("com.lemurbrowser.exts","url_bar")
2.AutofillHelpers.cs - add "com.lemurbrowser.exts"
3.autofillservice.xml - add compatibility-package tag

Lemur Browser is the mobile browser support Chrome and Edge extensions, build from chromium.

πŸ”— issue - #2260
πŸ”— Lemur Browser - https://www.lemurbrowser.com/
@CLAassistant
Copy link
Mannequin

CLAassistant mannequin commented Dec 25, 2022

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link
Mannequin

bitwarden-bot mannequin commented Dec 25, 2022

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PS-2116

@bitwarden-bot bitwarden-bot mannequin added the community-pr label Dec 25, 2022
@bitwarden-bot bitwarden-bot mannequin changed the title ✨ feat(Support): Add Lemur Browser [PS-2116] ✨ feat(Support): Add Lemur Browser Dec 25, 2022
@djsmith85 djsmith85 linked an issue Dec 27, 2022 that may be closed by this pull request
1 task
@Kevinlinpr
Copy link
Mannequin Author

Kevinlinpr mannequin commented Dec 28, 2022

@djsmith85 Please check this PR and review required, thanks.

@djsmith85 djsmith85 self-assigned this Dec 28, 2022
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevinlinpr Thank you for your contribution.

Changes are looking good, just one nit-pick and then this is ready to get merged.

Please move this up one line to ensure the sections are sorted alphabetically

6d5cb73
Copy link
Mannequin Author

@Kevinlinpr Kevinlinpr mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already move this up one line

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevinlinpr Thank you for the quick fix. Changes are looking good and your work will be included in the 2023.1 release πŸŽ‰

@djsmith85 djsmith85 merged commit 414cb9b into master Dec 30, 2022
@Kevinlinpr
Copy link
Mannequin Author

Kevinlinpr mannequin commented Dec 30, 2022

@djsmith85 Thank you for the quick merge.πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lemur Browser
5 participants