Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: SM-1403 review and update cpp sdk #1002

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Aug 29, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1403

📔 Objective

Update the C++ bindings to include the features we support and make the function parameters consistent with the other wrappers.

  • accessTokenLogin(token) -> loginAccessToken(token, stateFile)
  • updateProject(projectId, orgId, name) -> updateProject(orgId, projectId, name)
  • createSecret(key, value, note, orgId, {projectId}) -> createSecret(orgId, key, value, note, {projectId})
  • updateSecret(id, key, value, note, orgId, {projectId}) -> createSecret(orgId, id, key, value, note, {projectId})
  • add secret syncing
  • add getByIds
  • update the example wrapper to use the newer bindings as well as produce output for each project/secret operation

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Logo
Checkmarx One – Scan Summary & Details9c1d23f4-0e20-40d8-b92d-67e0f9a9dc31

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 136 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159 Attack Vector
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 106 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122 Attack Vector
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 138 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151 Attack Vector
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 55 Attack Vector

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (6f63639) to head (196e98b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files         197      197           
  Lines       13651    13651           
=======================================
  Hits         7913     7913           
  Misses       5738     5738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangowithfoxtrot tangowithfoxtrot changed the title Sm 1403 review and update cpp sdk SM-1403 review and update cpp sdk Aug 29, 2024
@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review August 29, 2024 21:26
@tangowithfoxtrot tangowithfoxtrot changed the title SM-1403 review and update cpp sdk breaking: SM-1403 review and update cpp sdk Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant