[SM-1237 Part 2] Add BitwardenClientInterface and Update cgo Flags

[coltonhurst]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

Description

Add the BitwardenClientInterface and related functions which will be used in integrations for mocks / testing. Update the cgo flags for multi-platform support via static linking.

Note

The -L /usr/local/lib -L /usr/lib locations were removed from the cgo lines. They only apply to Mac & Linux, and we are only currently supporting static linking. If anyone is opposed to removing these please let me know, I figure we can add them back if we want to support dynamic linking in the future.

Before you submit

• Please add unit tests where it makes sense to do so

[github-actions]

Checkmarx One – Scan Summary & Details – 7d0c58db-375c-4a4b-b2c3-4f62d08ba8c2

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/languages/go/example/example.go: 103	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Command_Injection	/languages/python/example.py: 66
	Command_Injection	/languages/python/example.py: 35
	Reflected_XSS	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
	Denial_Of_Service_Resource_Exhaustion	/languages/go/example/example.go: 15
	Denial_Of_Service_Resource_Exhaustion	/languages/go/example/example.go: 16
	Denial_Of_Service_Resource_Exhaustion	/languages/go/example/example.go: 21
	Missing_HSTS_Header	/languages/php/example.php: 3
	Parameter_Tampering	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
	Privacy_Violation	/languages/go/example/example.go: 103
	Privacy_Violation	/languages/go/example/example.go: 103
	Privacy_Violation	/languages/java/Example.java: 12
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40
	Privacy_Violation	/languages/java/Example.java: 13
	Unchecked_Input_for_Loop_Condition	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
	Missing_CSP_Header	/about.hbs: 48
	Use_of_Hardcoded_Password	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 73

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (0ca7dc4) to head (60dd2ab).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files         179      179           
  Lines       11652    11652           
=======================================
  Hits         6754     6754           
  Misses       4898     4898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tangowithfoxtrot]

Confirmed that we can still get a working, statically-linked Go executable on Linux with MUSL. Thanks!

[Thomas-Avery]

LGTM