-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1237 Part 2] Add BitwardenClientInterface and Update cgo Flags #792
Conversation
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 179 179
Lines 11652 11652
=======================================
Hits 6754 6754
Misses 4898 4898 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that we can still get a working, statically-linked Go executable on Linux with MUSL. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Objective
Description
Add the
BitwardenClientInterface
and related functions which will be used in integrations for mocks / testing. Update the cgo flags for multi-platform support via static linking.Note
The
-L /usr/local/lib -L /usr/lib
locations were removed from thecgo
lines. They only apply to Mac & Linux, and we are only currently supporting static linking. If anyone is opposed to removing these please let me know, I figure we can add them back if we want to support dynamic linking in the future.Before you submit