Update OpenAPI templates and generator #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference OpenAPI commit: 638af0fe37e2786ca3d6f5a8d764b346b2cc74a6
- Cargo.toml: better match what we use - model.mustache: int enum support and removed double optional - lib.mustache: disable some extra warnings - api.mustache: uuid support
dani-garcia
force-pushed
the
ps/update-openapi
branch
from
8bfde41
to
98ad6d1
Compare
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 58.55% 58.55%
=======================================
Files 178 178
Lines 11544 11544
=======================================
Hits 6760 6760
Misses 4784 4784 ☔ View full report in Codecov by Sentry. |
Hinton
reviewed
May 23, 2024
Hinton
approved these changes
May 23, 2024
dani-garcia
added a commit
that referenced
this pull request
May 24, 2024
## Type of change ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective Regenerate bindings based on the changes in #796 Based on server at commit bitwarden/server@a9ab894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Update OpenAPI templates and generator to the latest version available:
The first commit (5564407) contains the changes from upstream as-is, the second commit (1249b12) contains all the changes we need to make. This way it should be easier to apply the changes in the future.
The diff with upstream is a bit smaller now and also does less unnecessary allocations. Also I've updated the Cargo.toml template to more closely match ours. Once this is approved I'll make a separate PR to regenerate the bindings.
The changes to the generated bindings are fairly minor:
[JsonConverter(typeof(Base64UrlConverter))]on the server. We have some API endpoints that make use of it on the server but at the moment we're not using them.