Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate bindings based on #796 #797

Merged
merged 1 commit into from
May 24, 2024

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented May 23, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Regenerate bindings based on the changes in #796

Based on server at commit bitwarden/server@a9ab894

Copy link
Contributor

github-actions bot commented May 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsfb811767-ebc7-4968-b821-4c7daefe7e3b

No New Or Fixed Issues Found

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (5d8536b) to head (148c002).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   58.42%   58.42%           
=======================================
  Files         178      178           
  Lines       11555    11555           
=======================================
  Hits         6751     6751           
  Misses       4804     4804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hinton
Hinton previously approved these changes May 23, 2024
Base automatically changed from ps/update-openapi to main May 23, 2024 15:58
@dani-garcia dani-garcia dismissed Hinton’s stale review May 23, 2024 15:58

The base branch was changed.

@dani-garcia dani-garcia force-pushed the ps/update-openapi-regen-bindings branch from df72cc5 to 148c002 Compare May 23, 2024 16:05
@dani-garcia
Copy link
Member Author

Ugh the github automatic base change screwed up the PR, had to rebase it 😞

@dani-garcia dani-garcia requested a review from Hinton May 23, 2024 16:10
@dani-garcia dani-garcia merged commit f378a86 into main May 24, 2024
103 of 104 checks passed
@dani-garcia dani-garcia deleted the ps/update-openapi-regen-bindings branch May 24, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants