[SM-1287] Refactor out command logic from main.rs in bws #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltonhurst
changed the title
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 60.30% 59.68% -0.62%
==========================================
Files 189 192 +3
Lines 12361 12489 +128
==========================================
Hits 7454 7454
- Misses 4907 5035 +128 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Hinton
reviewed
May 30, 2024
Thomas-Avery
previously approved these changes
Jun 3, 2024
Hinton
reviewed
Jun 4, 2024
5 tasks
dani-garcia
reviewed
Jun 17, 2024
dani-garcia
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
SM-1287
📔 Objective
The goal of this PR is to refactor
bws/src/main.rsand theprocess_commands()function. This PR moves the actual CLI interaction for individual commands to thecommandmodule and appropriate sub-modules.There are plenty of other additions and changes to be made, but I'm trying to keep this PR a clean refactor and we can address other items in separate PR's.
Deprecation of the legacy CLI commands will happen in SM-1175.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes