Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the dependency between exporters and vault #833

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 11, 2024

๐Ÿ“” Objective

In preparation for #798 we need to flip the relationship between vault and exporters. Due to exporters in the future getting a client_exporters which means they need to be able to access the vault models to properly model it.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia June 11, 2024 09:48
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 15e5a497-ed64-41a0-bc48-353c05bf787b

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.24%. Comparing base (dfd0ba8) to head (8f6ebf6).

Files Patch % Lines
crates/bitwarden-exporters/src/models.rs 28.57% 10 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   59.23%   59.24%           
=======================================
  Files         186      186           
  Lines       12428    12426    -2     
=======================================
  Hits         7362     7362           
+ Misses       5066     5064    -2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton merged commit 3fc7fd2 into main Jun 11, 2024
104 checks passed
@Hinton Hinton deleted the ps/flip-export-vault branch June 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants