Explore new structure #798
Draft
+1,395
−1,165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hinton
changed the title
|
No New Or Fixed Issues Found |
Hinton
force-pushed
the
ps/core
branch
2 times, most recently
from
36d02d2
to
ab15ba3
Compare
# Conflicts: # Cargo.lock # crates/bitwarden-core/src/client/client.rs # crates/bitwarden-core/src/client/test_accounts.rs # crates/bitwarden-core/src/error.rs # crates/bitwarden-core/src/mobile/vault/client_sends.rs # crates/bitwarden-core/src/mobile/vault/client_vault.rs # crates/bitwarden-core/src/platform/domain.rs # crates/bitwarden-core/src/platform/fido2/crypto.rs # crates/bitwarden-core/src/platform/fido2/types.rs # crates/bitwarden-core/src/platform/sync.rs # crates/bitwarden-core/src/tool/mod.rs # crates/bitwarden-core/src/tool/send.rs # crates/bitwarden-core/src/vault/client_vault.rs # crates/bitwarden-core/src/vault/domain.rs # crates/bitwarden-core/src/vault/send.rs # crates/bitwarden-core/src/vault/sync.rs # crates/bitwarden/Cargo.toml # crates/bitwarden/src/lib.rs # crates/bitwarden/src/mobile/tool/client_sends.rs # crates/bitwarden/src/mobile/vault/client_sends.rs # crates/bitwarden/src/platform/domain.rs # crates/bitwarden/src/platform/sync.rs # crates/bitwarden/src/vault/send.rs
# Conflicts: # Cargo.lock # crates/bitwarden-core/Cargo.toml # crates/bitwarden-core/src/error.rs # crates/bitwarden-core/src/lib.rs # crates/bitwarden-core/src/uniffi_support.rs # crates/bitwarden-exporters/src/models.rs # crates/bitwarden-send/src/send.rs # crates/bitwarden-sm/src/projects/delete.rs # crates/bitwarden-sm/src/projects/project_response.rs # crates/bitwarden-sm/src/secrets/delete.rs # crates/bitwarden-sm/src/secrets/list.rs # crates/bitwarden-sm/src/secrets/secret_response.rs # crates/bitwarden-sm/src/secrets/sync.rs # crates/bitwarden/Cargo.toml
# Conflicts: # Cargo.lock # Cargo.toml # crates/bitwarden-core/src/auth/auth_request.rs # crates/bitwarden-core/src/auth/client_auth.rs # crates/bitwarden-core/src/auth/password/validate.rs # crates/bitwarden-core/src/client/internal.rs # crates/bitwarden-core/src/lib.rs # crates/bitwarden-core/src/mobile/crypto.rs # crates/bitwarden-core/src/mobile/vault/client_attachments.rs # crates/bitwarden-core/src/mobile/vault/client_ciphers.rs # crates/bitwarden-core/src/vault/cipher/attachment.rs # crates/bitwarden-core/src/vault/cipher/card.rs # crates/bitwarden-core/src/vault/cipher/cipher.rs # crates/bitwarden-core/src/vault/cipher/field.rs # crates/bitwarden-core/src/vault/cipher/identity.rs # crates/bitwarden-core/src/vault/cipher/linked_id.rs # crates/bitwarden-core/src/vault/cipher/local_data.rs # crates/bitwarden-core/src/vault/cipher/login.rs # crates/bitwarden-core/src/vault/cipher/mod.rs # crates/bitwarden-core/src/vault/cipher/secure_note.rs # crates/bitwarden-core/src/vault/collection.rs # crates/bitwarden-core/src/vault/domain.rs # crates/bitwarden-core/src/vault/folder.rs # crates/bitwarden-core/src/vault/password_history.rs # crates/bitwarden-core/src/vault/sync.rs # crates/bitwarden-core/src/vault/totp.rs # crates/bitwarden-exporters/src/models.rs # crates/bitwarden-sm/src/projects/create.rs # crates/bitwarden-sm/src/projects/update.rs # crates/bitwarden-sm/src/secrets/create.rs # crates/bitwarden-sm/src/secrets/update.rs # crates/bitwarden-vault/src/cipher/attachment.rs # crates/bitwarden-vault/src/cipher/card.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/cipher/field.rs # crates/bitwarden-vault/src/cipher/identity.rs # crates/bitwarden-vault/src/cipher/linked_id.rs # crates/bitwarden-vault/src/cipher/local_data.rs # crates/bitwarden-vault/src/cipher/login.rs # crates/bitwarden-vault/src/cipher/mod.rs # crates/bitwarden-vault/src/cipher/secure_note.rs # crates/bitwarden-vault/src/collection.rs # crates/bitwarden-vault/src/domain.rs # crates/bitwarden-vault/src/folder.rs # crates/bitwarden-vault/src/password_history.rs # crates/bitwarden-vault/src/totp.rs # crates/bitwarden/Cargo.toml # crates/bitwarden/src/error.rs # crates/bitwarden/src/tool/exporters/client_exporter.rs # crates/bitwarden/src/vault/cipher/attachment.rs # crates/bitwarden/src/vault/cipher/card.rs # crates/bitwarden/src/vault/cipher/cipher.rs # crates/bitwarden/src/vault/cipher/field.rs # crates/bitwarden/src/vault/cipher/identity.rs # crates/bitwarden/src/vault/cipher/linked_id.rs # crates/bitwarden/src/vault/cipher/local_data.rs # crates/bitwarden/src/vault/cipher/login.rs # crates/bitwarden/src/vault/cipher/mod.rs # crates/bitwarden/src/vault/cipher/secure_note.rs # crates/bitwarden/src/vault/collection.rs # crates/bitwarden/src/vault/domain.rs # crates/bitwarden/src/vault/folder.rs # crates/bitwarden/src/vault/password_history.rs # crates/bitwarden/src/vault/totp.rs
Hinton
added a commit
that referenced
this pull request
Jun 11, 2024
In preparation for #798 we need to flip the relationship between vault and exporters. Due to exporters in the future getting a `client_exporters` which means they need to be able to access the vault models to properly model it.
# Conflicts: # crates/bitwarden-core/src/auth/password/validate.rs # crates/bitwarden-core/src/auth/register.rs # crates/bitwarden-core/src/auth/renew.rs # crates/bitwarden-core/src/client/encryption_settings.rs # crates/bitwarden-core/src/mobile/crypto.rs # crates/bitwarden-core/src/platform/client_platform.rs # crates/bitwarden-core/src/platform/fido2/authenticator.rs # crates/bitwarden-core/src/platform/get_user_api_key.rs # crates/bitwarden-exporters/Cargo.toml # crates/bitwarden-exporters/src/lib.rs # crates/bitwarden-exporters/src/models.rs # crates/bitwarden-generators/src/client_generator.rs # crates/bitwarden-send/src/client_sends.rs # crates/bitwarden-sm/src/projects/create.rs # crates/bitwarden-sm/src/projects/update.rs # crates/bitwarden-sm/src/secrets/create.rs # crates/bitwarden-sm/src/secrets/update.rs # crates/bitwarden-uniffi/src/platform/mod.rs # crates/bitwarden-uniffi/src/tool/mod.rs # crates/bitwarden-uniffi/src/vault/ciphers.rs # crates/bitwarden-uniffi/src/vault/mod.rs # crates/bitwarden-vault/src/lib.rs # crates/bitwarden-vault/src/mobile/client_attachments.rs # crates/bitwarden-vault/src/mobile/client_ciphers.rs # crates/bitwarden-vault/src/mobile/client_collection.rs # crates/bitwarden-vault/src/mobile/client_folders.rs # crates/bitwarden-vault/src/mobile/client_password_history.rs # crates/bitwarden-vault/src/sync.rs # crates/bitwarden/src/client/client.rs # crates/bitwarden/src/error.rs # crates/bitwarden/src/tool/exporters/client_exporter.rs # crates/bitwarden/src/tool/exporters/mod.rs # crates/bitwarden/src/vault/client_vault.rs
# Conflicts: # Cargo.lock # Cargo.toml # crates/bitwarden-core/src/platform/client_fido.rs # crates/bitwarden-core/src/platform/client_platform.rs # crates/bitwarden-core/src/platform/fido2/authenticator.rs # crates/bitwarden-core/src/platform/fido2/client.rs # crates/bitwarden-core/src/platform/fido2/crypto.rs # crates/bitwarden-core/src/platform/fido2/mod.rs # crates/bitwarden-core/src/platform/fido2/traits.rs # crates/bitwarden-core/src/platform/fido2/types.rs # crates/bitwarden-fido/src/authenticator.rs # crates/bitwarden-fido/src/client.rs # crates/bitwarden-fido/src/crypto.rs # crates/bitwarden-fido/src/lib.rs # crates/bitwarden-fido/src/traits.rs # crates/bitwarden-fido/src/types.rs # crates/bitwarden-json/src/client.rs # crates/bitwarden-send/Cargo.toml # crates/bitwarden-send/src/lib.rs # crates/bitwarden-send/src/send.rs # crates/bitwarden-send/src/uniffi_support.rs # crates/bitwarden-uniffi/src/vault/ciphers.rs # crates/bitwarden/Cargo.toml # crates/bitwarden/src/error.rs # crates/bitwarden/src/platform/fido2/authenticator.rs # crates/bitwarden/src/platform/fido2/client.rs # crates/bitwarden/src/platform/fido2/crypto.rs # crates/bitwarden/src/platform/fido2/mod.rs # crates/bitwarden/src/platform/fido2/traits.rs # crates/bitwarden/src/platform/fido2/types.rs # crates/bitwarden/src/secrets_manager/client_projects.rs # crates/bitwarden/src/secrets_manager/client_secrets.rs # crates/bitwarden/src/tool/mod.rs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # crates/bitwarden-core/README.md # crates/bitwarden-json/src/client.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bw/src/main.rs
# Conflicts: # Cargo.lock # crates/bitwarden-core/src/platform/mod.rs # crates/bitwarden-fido/src/authenticator.rs # crates/bitwarden-fido/src/client_fido.rs # crates/bitwarden-fido/src/lib.rs # crates/bitwarden-uniffi/src/platform/fido2.rs # crates/bitwarden/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Explore if we can have teams build their own feature crates and depend on a shared
corecrate.Code changes
Before you submit