Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fido2 credential autofill view #849

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Jun 17, 2024

🎟️ Tracking

📔 Objective

This PR adds a function on the Fido2 authenticator which returns all available credentials as a View tailored specifically for integrating with OS-level autofill APIs

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsae27b337-cbdb-4f40-b503-3d28c4ed89bb

No New Or Fixed Issues Found

crates/bitwarden-fido/src/types.rs Fixed Show fixed Hide fixed
crates/bitwarden-fido/src/types.rs Fixed Show fixed Hide fixed
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 102 lines in your changes missing coverage. Please review.

Project coverage is 59.83%. Comparing base (32ac1e4) to head (3dd6821).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/bitwarden-fido/src/types.rs 0.00% 35 Missing ⚠️
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 29 Missing ⚠️
crates/bitwarden-fido/src/authenticator.rs 0.00% 27 Missing ⚠️
crates/bitwarden/src/platform/client_fido.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   60.30%   59.83%   -0.47%     
==========================================
  Files         189      189              
  Lines       12361    12457      +96     
==========================================
  Hits         7454     7454              
- Misses       4907     5003      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu requested a review from dani-garcia June 17, 2024 10:03
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just a question about some duplication introduced by the new credentials_for_autofill

crates/bitwarden-fido/Cargo.toml Show resolved Hide resolved
crates/bitwarden-uniffi/src/platform/fido2.rs Show resolved Hide resolved
crates/bitwarden-fido/src/types.rs Show resolved Hide resolved
@coroiu coroiu merged commit 547d0f2 into main Jun 18, 2024
103 checks passed
@coroiu coroiu deleted the add-fido2-credential-autofill-view branch June 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants