Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access code generation to use alphanumerical #853

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 18, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Currently auth requests uses the password generator to generate a 25 character password. Since we're shuffling around code for #798 this won't be possible much longer.

This PR adds a generate_random_alphanumeric to the bitwarden_crypto crate which generates a cryptographically secure random alphanumerical string that can be used instead.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 807555ec-471f-4997-a805-8a7f13c38ab4

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 59.79%. Comparing base (547d0f2) to head (c369f92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   59.83%   59.79%   -0.05%     
==========================================
  Files         189      189              
  Lines       12457    12453       -4     
==========================================
- Hits         7454     7446       -8     
- Misses       5003     5007       +4     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton requested review from dani-garcia, a team and rr-bw June 18, 2024 14:11
@rr-bw rr-bw requested a review from jlf0dev June 20, 2024 19:09
@rr-bw rr-bw removed their request for review June 20, 2024 19:29
@Hinton Hinton merged commit 72dd93b into main Jun 24, 2024
207 checks passed
@Hinton Hinton deleted the ps/access-code branch June 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants