CSA-6 Fix/remove artifact binding #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Remove Artifact binding capabilities from Bitwarden's SSO service for now; they may be added back in the future.
see: https://app.asana.com/0/1169444489336079/1201340159635915/f
see: CSA-6
Code changes
SAMLart
parameter. Dont' let the name fool you, this is not to stifle login creativity or self-expression through art,SAMLart
is the artifact binding parameter itself and should not be allowedset
operations against the model. This is to provide backwards compatibility against JSON requests and stored JSON to prevent serialization/deserialization errors and keep compatibility with older clients.Testing requirements
Documentation updates
cc: @fschillingeriv
Because this removes the underlying functionality for the Artifact binding and associated Artifact Endpoint URL configuration in the UI when configuring SAML, this update will need to be made to the documentation when this goes live (likely in March release). A similar PR will remove this from the UI itself.
Before you submit
dotnet tool run dotnet-format --check
) (required)