Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-589] Fix DeviceUnknownVerification User_Update proc #2041

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jun 8, 2022

Type of change (mark with an X)

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fix 2022-05-24_00_DeviceUnknownVerification User_Update stored procedure to remove the NULL on the UnknownDeviceVerificationEnabled parameter and set the default value on it

Code changes

  • 2022-05-24_00_DeviceUnknownVerification.sql: Removed NULL and set default value on UnknownDeviceVerificationEnabled on the User_Update stored procedure

Before you submit (mark with an X)

- [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required)
- [ ] If making database changes - I have also updated Entity Framework queries and/or migrations
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

@fedemkr fedemkr requested review from acostarj, a team and joseph-flinn and removed request for acostarj June 8, 2022 14:42
joseph-flinn
joseph-flinn previously approved these changes Jun 8, 2022
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we updated the refrence sproc in the sqlproj?

…VerificationEnabled with default 1 instead of NULL
Copy link
Member

@joseph-flinn joseph-flinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Might want confirmation from Oscar as I'm not an expert in this area.

@fedemkr fedemkr enabled auto-merge (squash) June 13, 2022 14:03
@fedemkr fedemkr merged commit e369915 into master Jun 13, 2022
@fedemkr fedemkr deleted the PS-589-fix-user-update-proc-default branch June 13, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants