Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC-400] Code clean up Device Verification #2601

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 19, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove the code introduced by Device Verification feature.
Related PRs:

Code changes

  • TwoFactorController: I was in doubt here whether to remove the endpoints, so I just marked them as obsolete and changed them to return a default value. These endpoints were being used in the web client but were removed in this PR. Leaving them here in case a self hosted instance has an old version of the web client. LMK if I should just remove them or change something else
  • DeviceVerificationRequestModel, DeviceVerificationResponseModel: I left these model just because of the obsolete endpoints aforementioned. LMK if I should remove them as well.
  • Database changes: Removed the column UnknownDeviceVerificationEnabled from the User table.
  • others: Removed code introduced by the aforementioned PRs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr requested a review from a team January 19, 2023 16:50
Copy link
Member

@jlf0dev jlf0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Sad to see all that effort go, but at least the 2f code looks a little cleaner now 👍

@fedemkr fedemkr merged commit 6951116 into master Feb 17, 2023
@fedemkr fedemkr deleted the EC-400-code-clean-up-device-verification branch February 17, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants