Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ef query joins with multi-condition ON clauses #2386

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

kspearrin
Copy link
Member

https://bitwarden.atlassian.net/browse/PS-1806

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Several EF queries that deal with organization collection, group, and cipher access are not performing their JOINs correctly. This PR is the start of correcting those joins.

Code changes

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@kspearrin kspearrin changed the title fix ef query joins with multi-on conditions fix ef query joins with multiple conditions ON clauses Nov 5, 2022
@kspearrin kspearrin changed the title fix ef query joins with multiple conditions ON clauses fix ef query joins with multi-condition ON clauses Nov 5, 2022
@kspearrin kspearrin merged commit 3e092be into master Nov 7, 2022
@kspearrin kspearrin deleted the effix8 branch November 7, 2022 17:08
kspearrin added a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants