Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-1806 - add missing null coalesce from ea TSQL view #2423

Merged
merged 1 commit into from Nov 18, 2022
Merged

Conversation

kspearrin
Copy link
Member

@kspearrin kspearrin commented Nov 18, 2022

https://bitwarden.atlassian.net/browse/PS-1806

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Emergency Access View in TSQL has a null coalesce on GrantorEmail. See https://github.com/bitwarden/server/blob/master/src/Sql/dbo/Views/EmergencyAccessDetailsView.sql.

This was missing in the EF implementation.

Code changes

  • EmergencyAccessDetailsViewQuery.cs: Add coalesce logic back to EA email field.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@kspearrin kspearrin merged commit 3481fd7 into master Nov 18, 2022
@kspearrin kspearrin deleted the efeafix1 branch November 18, 2022 19:37
kspearrin added a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants