Auth/PM-5092 - Registration with Email verification - Send Email Verification Endpoint #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terSendEmailVerification
…sting verify email.
…tly written + register as scoped.
… the existing email verification token.
…d call to mail service to send email.
…on logic in place.
… remove modelState invalid check as .NET literally executes this validation pre-method execution.
…ustom email for registration verify email.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4173 +/- ##
==========================================
+ Coverage 40.60% 40.68% +0.07%
==========================================
Files 1232 1239 +7
Lines 59518 59492 -26
Branches 5470 5434 -36
==========================================
+ Hits 24170 24206 +36
+ Misses 34208 34160 -48
+ Partials 1140 1126 -14 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
…he 2 params which should have been nullable based on the constructor logic (2) Add new ReferenceEventType.cs for email verification register submit (3) Update AccountsController.cs to log new reference event (4) Update tests
…pose, and token id to include registration to differentiate it from the existing email verification token.
JaredSnider-Bitwarden
changed the title
…me as it is optional.
|
After addressing all PR feedback, I ran through the 4 primary test scenarios for the endpoint again using web. |
…red in client side registration step to create a master key.
…ttps://github.com/bitwarden/server into auth/pm-5092/email-verification-send-email-endpoint
| @@ -4,9 +4,11 @@ namespace Bit.Core.Auth.Models.Mail; | |||
|
|
|||
| public class RegisterVerifyEmail : BaseMailModel | |||
| { | |||
| public string Url => string.Format("{0}/finish-signup?token={1}", | |||
| public string Url => string.Format("{0}/finish-signup?token={1}&email={2}", | |||
There was a problem hiding this comment.
Adding email to URL so that the registration finish component can have access to email in order to create a master key once the user enters their MP.
audreyality
requested changes
Jun 18, 2024
…ath and PlanUpgradePath nullable
…e reference event.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jlf0dev
previously approved these changes
Jun 19, 2024
...uth/UserFeatures/Registration/Implementations/SendVerificationEmailForRegistrationCommand.cs
Show resolved
Hide resolved
JaredSnider-Bitwarden
dismissed stale reviews from jlf0dev and audreyality
via
a9d0b99
jlf0dev
approved these changes
Jun 19, 2024
audreyality
approved these changes
Jun 19, 2024
|
Merging as all the new changes are feature flagged. |
JaredSnider-Bitwarden
deleted the
auth/pm-5092/email-verification-send-email-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-5092
Associated clients PR: bitwarden/clients#9573
📔 Objective
To create a new endpoint to service the new email verification step in the new registration process.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes