[PM-5093][PM-7325] Added trial initiation email verification endpoint #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorask-bitwarden
previously approved these changes
Jun 24, 2024
|
|
||
| if (!globalSettings.EnableEmailVerification) | ||
| { | ||
| await PerformConstantTimeOperationsAsync(); |
There was a problem hiding this comment.
❓ Not a blocker, just curious what the Task.Delay is for?
There was a problem hiding this comment.
Good question, I just pushed a change adding an explanatory comment. The idea is to mitigate timing attacks where an attacker can detect if a user exists based on how long the request takes to complete
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
- Coverage 41.65% 41.59% -0.07%
==========================================
Files 1271 1276 +5
Lines 60197 60294 +97
Branches 5528 5534 +6
==========================================
+ Hits 25078 25082 +4
- Misses 33949 34042 +93
Partials 1170 1170 ☔ View full report in Codecov by Sentry. |
|
New Issues
|
amorask-bitwarden
previously approved these changes
Jun 24, 2024
amorask-bitwarden
approved these changes
Jul 29, 2024
cturnbull-bitwarden
deleted the
billing/PM-5093/send-trial-initiation-email
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-5093
https://bitwarden.atlassian.net/browse/PM-7325
📔 Objective
This pull request adds a billing controller
src\Identity\Billing\Controller\AccountsController.cswith the single endpointPostTrialInitiationSendVerificationEmailAsync. This endpoint is behind Auth's feature flagemail-verificationas it relies on their work.This PR duplicates some of the work done in #4173 but places it in billing-owned code related to initiating a new trial.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes