Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CKEditor paste event listeners #2998

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove CKEditor paste event listeners #2998

merged 1 commit into from
Jul 10, 2024

Conversation

DaniBitZesty
Copy link
Contributor

📝 A short description of the changes

  • Remove CKEditor error message and use our custom validations when word limit is exceeded.
  • The removed code from CKEditor plugin also stopped user from entering more words beyond the limit, we didn't want this behaviour.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Copy link
Contributor

@saenom saenom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the PR :-)

@DaniBitZesty DaniBitZesty merged commit a67aeba into main Jul 10, 2024
12 checks passed
@DaniBitZesty DaniBitZesty deleted the wordcount branch July 10, 2024 10:24
@TheDancingClown TheDancingClown mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants