Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to stable cadence flowkit and fix tests #137

Merged
merged 25 commits into from
Feb 26, 2024
Merged

update to stable cadence flowkit and fix tests #137

merged 25 commits into from
Feb 26, 2024

Conversation

bjartek
Copy link
Owner

@bjartek bjartek commented Aug 31, 2023

Closes #???

Description


For contributor use:

  • Targeted PR against main branch
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Pull Request Test Coverage Report for Build 6551031298

  • 31 of 33 (93.94%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.0%) to 78.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
npm_module.go 16 18 88.89%
Totals Coverage Status
Change from base Build 6548297611: 4.0%
Covered Lines: 2517
Relevant Lines: 3210

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Unit Test Results

218 tests   - 42   218 ✔️  - 42   43s ⏱️ -1s
    6 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit c7907ed. ± Comparison against base commit 6e86330.

This pull request removes 260 and adds 218 tests. Note that renamed tests count towards both.
github.com/bjartek/overflow ‑ Example
github.com/bjartek/overflow ‑ ExampleOverflowState_Script
github.com/bjartek/overflow ‑ ExampleOverflowState_Script_inline
github.com/bjartek/overflow ‑ ExampleOverflowState_Tx
github.com/bjartek/overflow ‑ ExampleOverflowState_Tx_inline
github.com/bjartek/overflow ‑ ExampleOverflowState_Tx_multisign
github.com/bjartek/overflow ‑ TestCadenceValueToInterface
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/Emoji
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/EmojiDict
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/EmptyString
…
github.com/bjartek/overflow/v2 ‑ Example
github.com/bjartek/overflow/v2 ‑ ExampleOverflowState_Script
github.com/bjartek/overflow/v2 ‑ ExampleOverflowState_Script_inline
github.com/bjartek/overflow/v2 ‑ ExampleOverflowState_Tx
github.com/bjartek/overflow/v2 ‑ ExampleOverflowState_Tx_inline
github.com/bjartek/overflow/v2 ‑ ExampleOverflowState_Tx_multisign
github.com/bjartek/overflow/v2 ‑ TestErrorsInAccountCreation
github.com/bjartek/overflow/v2 ‑ TestErrorsInAccountCreation/Should_deploy_contracts_to_multiple_accounts
github.com/bjartek/overflow/v2 ‑ TestErrorsInAccountCreation/Should_give_error_on_invalid_env_var_in_flow.json
github.com/bjartek/overflow/v2 ‑ TestErrorsInAccountCreation/Should_give_error_on_wrong_account_name
…

♻️ This comment has been updated with latest results.

@bjartek
Copy link
Owner Author

bjartek commented Nov 29, 2023

closes #142

@bjartek bjartek marked this pull request as ready for review February 26, 2024 10:19
@bjartek bjartek merged commit 4a9b777 into main Feb 26, 2024
5 checks passed
@bjartek bjartek deleted the stable-cadence branch February 26, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant