Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use underflow #155

Merged
merged 5 commits into from
Feb 26, 2024
Merged

use underflow #155

merged 5 commits into from
Feb 26, 2024

Conversation

bjartek
Copy link
Owner

@bjartek bjartek commented Feb 16, 2024

Closes #151

Copy link

github-actions bot commented Feb 16, 2024

Unit Test Results

213 tests   - 47   213 ✔️  - 47   44s ⏱️ ±0s
    6 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 5eeff2b. ± Comparison against base commit 6e86330.

This pull request removes 47 tests.
github.com/bjartek/overflow ‑ TestCadenceValueToInterface
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/Emoji
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/EmojiDict
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/EmptyString
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/Event
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/None
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/Some(string)
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/Some(uint64)
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/StoragePath
github.com/bjartek/overflow ‑ TestCadenceValueToInterface/address
…

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 8040108377

Details

  • -13 of 50 (74.0%) changed or added relevant lines in 8 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.1%) to 72.871%

Changes Missing Coverage Covered Lines Changed/Added Lines %
result.go 0 1 0.0%
script.go 2 3 66.67%
setup.go 1 6 16.67%
transaction.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
interaction_builder.go 1 84.57%
script.go 1 76.38%
state.go 1 82.13%
utils.go 9 89.52%
Totals Coverage Status
Change from base Build 7928330844: -1.1%
Covered Lines: 2114
Relevant Lines: 2901

💛 - Coveralls

@bjartek bjartek changed the base branch from main to stable-cadence February 25, 2024 19:12
@bjartek bjartek merged commit cfc1784 into stable-cadence Feb 26, 2024
@bjartek bjartek deleted the use-underflow branch February 26, 2024 09:42
bjartek added a commit that referenced this pull request Feb 26, 2024
* update to stable cadence flowkit and fix tests

* tidy

* removed restricted types and fixed tests

* started updating overflow to new stable cadence

* fixed remaining errors

* added AuthorizerTypes to OverflowResult

* update to stable-cadence.3

* add error message if you are creating account with a configured address and another one is created

* fixed tests with some TODOs regarding computation (#147)

* fixed tests with some TODOs regarding computation

* bump to latest version of stable-cadence

* fix: fix filtering out so we do not filter out NFT events

* filter out temp events

* added propper Authorizers to bot transactions parsed and send in

* try to give better error message when a transaction fails, include the filename

* added require versions of assert failure and success

* feat: implemented custom options to a tx to assert events and failure/success using builder methods

* fix: added helper to change an EventAssertion with replacing a field

* feat: update to new cli version

* fix: update to new flowkit

* fix: fixed tests

* add raw event to OverflowEvent

* merge main and fix tests

* use underflow (#155)

* use underflow

* allow setting underflow option and use that. breaks a bit of bc

* use new version of underflow

* tidy

* migrate to v2, fix warnigns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract out code that has only cadence dependencies
2 participants