Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthContext should handle Authentication Error Response #549

Open
mancioshell opened this issue Mar 25, 2021 · 4 comments
Open

AuthContext should handle Authentication Error Response #549

mancioshell opened this issue Mar 25, 2021 · 4 comments

Comments

@mancioshell
Copy link
Contributor

mancioshell commented Mar 25, 2021

If any error occurs in Authentication Response, AuthContext skip hasCodeInUrl and enters in a loop calling userManager.signinRedirect() every time.

Maybe hasCodeInUrl should be parse error parameter as specified in the Authentication Error Response specification.

@simenandre
Copy link
Member

I absolutely agree!

Maybe you wanna contribute to that? We have talked about improving the functionality of hasCodeInUrl and related functionality before (#313).

@simenandre
Copy link
Member

@mancioshell what do you think about incorporating the way @pamapa mentioned, where we use oidc-client native functions? Mind you, have a look at #652. Personally, I think this can be solved with a similar PR like you've made in #552.

Regardless of what you end up doing, thank you so much for contributing! 🙏

@marlena-sliwinska
Copy link

Is there any possibility, that you will solve this issue and add some error handling?

@simenandre
Copy link
Member

simenandre commented Mar 12, 2023

Hi @marlena-sliwinska 👋

I don't think anyone is working on this, so feel free to contribute! You can join our Discord server (or post questions here) if you want help with anything in that regard. https://discord.gg/SXMpgmPq5F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants