Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AuthContext): added onSignInError prop to handle Authentication … #552

Conversation

mancioshell
Copy link
Contributor

…Error Response #549

@update-docs
Copy link

update-docs bot commented Mar 25, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #552 (eef4677) into master (2957e85) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head eef4677 differs from pull request most recent head 1eae747. Consider uploading reports for the commit 1eae747 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   98.48%   98.73%   +0.24%     
==========================================
  Files           1        1              
  Lines          66       79      +13     
  Branches       17       24       +7     
==========================================
+ Hits           65       78      +13     
  Partials        1        1              
Impacted Files Coverage Δ
src/AuthContext.tsx 98.73% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2957e85...1eae747. Read the comment docs.

@pamapa
Copy link
Contributor

pamapa commented Apr 10, 2021

This seems the wrong way. The oidc-client is responsible for this kind functionality! We should really stop parsing the url...

Instead we should register on addSilentRenewError can track this via an internal error state or the not yet existing AuthState/reducer....

@simenandre
Copy link
Member

This seems the wrong way. The oidc-client is responsible for this kind functionality! We should really stop parsing the url...

Instead we should register on addSilentRenewError can track this via an internal error state or the not yet existing AuthState/reducer....

@pamapa Thanks for that feedback! I tend to agree, maybe you can help out with some thoughts on #549 and #313?

@pamapa
Copy link
Contributor

pamapa commented Apr 10, 2021

@cobraz I will provide a merge request using the addSilentRenewError way to go...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants