Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset tile properties are now wrapped in <objectGroup> #1581

Closed
mtdowling opened this issue May 29, 2017 · 2 comments
Closed

Tileset tile properties are now wrapped in <objectGroup> #1581

mtdowling opened this issue May 29, 2017 · 2 comments

Comments

@mtdowling
Copy link

After upgrading to Tiled 1.0 (awesome update, btw!), I'm seeing that custom properties added to tileset tiles are now nested under <objectGroup><properties></properties></objectGroup> in the save tileset XML data rather than just placing <properties> directly inside of each <tile>.

How the issue can reproduced:

Load a tileset in Tiled 1.0 that was created using a pre-1.0 version of Tiled for which tiles have custom properties. Click on a tile. Notice that none of the custom properties that were applied to the tile are shown in the "Custom properties" window pane. Now add a new property to the tile and save the tileset. Now open the tileset and look at that tile. The tile now has a definition like the following:

<tile id="714">
  <properties>
   <property name="foo" type="bool" value="true"/>
   <property name="baz" value="Bar"/>
  </properties>
  <objectgroup draworder="index">
   <properties>
     <property name="foo" type="bool" value="true"/>
     <property name="baz" value="Bar"/>
   </properties>
  </objectgroup>
 </tile>

What behavior you expected instead

  1. I would expect that properties add to tilesets created before the 1.0 release show up in the custom properties panel in the tileset editor.
  2. I don't see the reason for wrapping custom properties of a tile in a tileset in the <objectGroup> node. I would have expected that custom properties added to tiles in a tileset just get placed in a <properties> element directly inside of the <tile> element rather than wrapping it in an <objectGroup> element.

What actually happened

Answered above.

Tiled version, operating system, etc. if possibly relevant.

1.0 on a Mac.

@bjorn
Copy link
Member

bjorn commented May 29, 2017

Hmm, you seem to be editing the properties of the object group rather than those of the tile. This happens when you are in "collision editor" mode. Do you have the collision editor open? In that case just close that to change the properties of the tiles themselves.

Probably this is something that should somehow be made more clear...

@mtdowling
Copy link
Author

You're correct! Thanks for the quick response.

I didn't even know you could edit object group properties like that. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants