Skip to content

Commit

Permalink
Auto merge of rust-lang#116167 - RalfJung:structural-eq, r=lcnr
Browse files Browse the repository at this point in the history
remove StructuralEq trait

The documentation given for the trait is outdated: *all* function pointers implement `PartialEq` and `Eq` these days. So the `StructuralEq` trait doesn't really seem to have any reason to exist any more.

One side-effect of this PR is that we allow matching on some consts that do not implement `Eq`. However, we already allowed matching on floats and consts containing floats, so this is not new, it is just allowed in more cases now. IMO it makes no sense at all to allow float matching but also sometimes require an `Eq` instance. If we want to require `Eq` we should adjust rust-lang#115893 to check for `Eq`, and rule out float matching for good.

Fixes rust-lang#115881
  • Loading branch information
bors committed Jan 26, 2024
2 parents 50a067d + adbc676 commit e8d600f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions example/mini_core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@ unsafe impl<T: ?Sized> Freeze for &mut T {}
#[lang = "structural_peq"]
pub trait StructuralPartialEq {}

#[lang = "structural_teq"]
pub trait StructuralEq {}

#[lang = "not"]
pub trait Not {
type Output;
Expand Down

0 comments on commit e8d600f

Please sign in to comment.